Directory Traversal Affecting github.com/go-goyave/goyave package, versions >=5.0.0 <5.5.0

Affected versions of this package are vulnerable to Directory Traversal due to improper sanitization of user-supplied input in the router.Static and osfs.FS components. An attacker can access arbitrary files on the host system by manipulating file paths to include relative path segments such as ...

Note: This is only exploitable if the Go application system user has read access to the requested file.

This vulnerability can be mitigated by using fsutil.NewEmbed(embeddedFS) from the goyave.dev/goyave/v5/util/fsutil package to serve static content using Router.Static instead of &osfs.FS. Embedded file systems are rooted in the specified directory, making navigating outside the developers' intended directory impossible.

import (
    "embed"
    "goyave.dev/goyave/v5/util/fsutil"
)

//go:embed resources
var resources embed.FS
//...
fs := fsutil.NewEmbed(resources)
router.Static(fs, "/resources", false)

import (
    "goyave.dev/goyave/v5"
    "goyave.dev/goyave/v5/util/fsutil/osfs"
)

func Register(server *goyave.Server, router *goyave.Router) {
    fs, err := (&osfs.FS{}).Sub("resources")
    if err != nil {
        //...
        return
    }
    router.Static(fs, "/resources", false)
}

curl http://localhost:8080/resources/../../some/file

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

• Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

• Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

• GitHub Commit
• GitHub Issue