Directory Traversal Affecting github.com/victoriametrics/victoriametrics/lib/backup/common package, versions <1.122.25>=1.123.0 <1.136.12>=1.137.0 <1.146.0

Affected versions of this package are vulnerable to Directory Traversal through the restore path handling in lib/backup/actions/restore.go, lib/backup/common/part.go, and lib/backup/fslocal/fslocal.go. An attacker can write or overwrite files outside the configured -storageDataPath by supplying a crafted backup source whose object names contain .. path components. This can place arbitrary files on the host running vmrestore, limited by the process’s filesystem permissions, and can corrupt or replace files outside the intended restore directory.

Workarounds

• Restrict write access to the backup storage source used as -src so only trusted, least-privileged principals can modify bucket objects; this prevents an attacker from planting crafted .. object names that cause vmrestore to write outside -storageDataPath.

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

• Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

• Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

• GitHub Commit
• Maintainer's Advisory